added http-proxy to fix image uploads #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Sorry for the double pull request. I renamed my branch after the pull request. |
luismesas
added a commit
that referenced
this pull request
Mar 2, 2015
added http-proxy to fix image uploads
ghost
deleted the
luismesas
pushed a commit
that referenced
this pull request
Feb 8, 2016
Stringify body in prepareOptions middleware only if body exists, in o…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created this branch adding
http-proxymodule to pipe the request/response "as-is" without modification directly to target server. This mode is active only for ulrs matching the patterns in config.directProxyUrls list. This solves the issue #6.There is also a new middleware bodyParserWrapper that apply the middleware based on configuration for some urls.
I left the rest of the proxied requests with the original code using
request. But I strongly suggest to switch all requests to usehttp-proxyso you won't need any further analysis/parse of the request/response. Thehttp-proxymodule is very flexible and powerful.